Added support of Predis library as storage adapter #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Łukasz Adamczewski <[email protected]>
|
I'm currently looking into adding |
Open
pioniro
reviewed
Nov 20, 2024
| @@ -586,7 +593,7 @@ private function collectGauges(bool $sortMetrics = true): array | |||
| sort($keys); | |||
| $gauges = []; | |||
| foreach ($keys as $key) { | |||
| $raw = $this->redis->hGetAll(str_replace($this->redis->_prefix(''), '', $key)); | |||
| $raw = $this->redis->hGetAll(str_replace($this->prefix(''), '', $key)); | |||
There was a problem hiding this comment.
$this->prefix('') is always an empty string for this adater, but $key contains the prefix to remove.
perhaps $this->removePrefixFromKey($key) was intended here ?
The same applies to collectHistograms, collectGauges
Suggested change
| $raw = $this->redis->hGetAll(str_replace($this->prefix(''), '', $key)); | |
| $raw = $this->redis->hGetAll($this->removePrefixFromKey($key)); |
| @@ -622,7 +629,7 @@ private function collectCounters(bool $sortMetrics = true): array | |||
| sort($keys); | |||
| $counters = []; | |||
| foreach ($keys as $key) { | |||
| $raw = $this->redis->hGetAll(str_replace($this->redis->_prefix(''), '', $key)); | |||
| $raw = $this->redis->hGetAll(str_replace($this->prefix(''), '', $key)); | |||
There was a problem hiding this comment.
Suggested change
| $raw = $this->redis->hGetAll(str_replace($this->prefix(''), '', $key)); | |
| $raw = $this->redis->hGetAll($this->removePrefixFromKey($key)); |
| @@ -403,7 +411,7 @@ private function collectHistograms(): array | |||
| sort($keys); | |||
| $histograms = []; | |||
| foreach ($keys as $key) { | |||
| $raw = $this->redis->hGetAll(str_replace($this->redis->_prefix(''), '', $key)); | |||
| $raw = $this->redis->hGetAll(str_replace($this->prefix(''), '', $key)); | |||
There was a problem hiding this comment.
Suggested change
| $raw = $this->redis->hGetAll(str_replace($this->prefix(''), '', $key)); | |
| $raw = $this->redis->hGetAll($this->removePrefixFromKey($key)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since predis library is a well-known alternative to phpredis, I've decided to add an extension to Redis storage adapter.
Some properties and methods were changed to protected in order to handle slight differences between these 2 libs.
Mostly additional params are passed as an array in phpredis and as single arguments in predis.