Skip to content

Commit

Permalink
Skyline: Minor tweaks to AbstractFunctionalTest for screenshots
Browse files Browse the repository at this point in the history
- Fix Skyline icon displaying on control-box forms
- Always WaitForGraphs it taking a screenshot in PauseForScreenShot
  • Loading branch information
brendanx67 committed Dec 10, 2024
1 parent c881af9 commit 070ef48
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pwiz_tools/Skyline/TestUtil/TestFunctional.cs
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ protected static TDlg ShowDialog<TDlg>(Action act, int millis = -1) where TDlg :
if (IsRecordingScreenShots && dlg.ShowIcon && !ReferenceEquals(dlg, SkylineWindow))
{
if (dlg.FormBorderStyle != FormBorderStyle.FixedDialog ||
dlg.Icon != null) // Normally a fixed dialog will not have the Skyline icon handle
dlg.Icon.Handle == Resources.Skyline.Handle) // Normally a fixed dialog will not have the Skyline icon handle
{
var ico = dlg.Icon.Handle;
if (ico != SkylineWindow.Icon.Handle)
Expand Down Expand Up @@ -1882,6 +1882,8 @@ private void PauseForScreenShotInternal(string description, Type formType = null
Thread.Sleep(Program.PauseSeconds * 1000);
else if ((IsPauseForScreenShots || IsAutoScreenShotMode) && Math.Max(PauseStartingPage, Program.PauseStartingPage) <= ScreenshotCounter)
{
WaitForGraphs(); // Screenshots always need graphs to be fully updated

if (screenshotForm == null)
{
if (!fullScreen && formType != null)
Expand Down

0 comments on commit 070ef48

Please sign in to comment.