Fix Unhandled Error if skyd file can't be read when showing Protein t…

…ooltip (#2740)

Fixed Unhandled Error hovering over Protein in Targets tree if .skyd file cannot be read (reported on Exception Web)

pwiz_tools/Shared/CommonUtil/SystemUtil/ParallelEx.cs

@@ -142,6 +142,8 @@ private static void LoopWithExceptionHandling(Action loop, Action<AggregateExcep
                         throw new IOException(ex.Message, ex);
                     if (ex is OperationCanceledException)
                         throw new OperationCanceledException(ex.Message, ex);
+                    if (ex is UnauthorizedAccessException)
+                        throw new UnauthorizedAccessException(ex.Message, ex);
                     throw new TargetInvocationException(ex.Message, ex);
                 }
                 if (catchClause != null)

pwiz_tools/Skyline/Controls/SeqNode/SrmTreeNode.cs

@@ -1103,7 +1103,18 @@ private void Timer_Tick(Object sender, EventArgs e)
             _timer.Stop();
             if (_tipDisplayer == null || !_tipDisplayer.AllowDisplayTip)
                 return;
+            try
+            {
+                DisplayTip();
+            }
+            catch (Exception exception)
+            {
+                ExceptionUtil.DisplayOrReportException(this, exception, Resources.NodeTip_Timer_Tick_An_error_occurred_displaying_a_tooltip_);
+            }
+        }
 
+        private void DisplayTip()
+        {
             Rectangle rectScreen = _tipDisplayer.ScreenRect;
             AnimateMode animate = AnimateMode.SlideTopToBottom;
 

pwiz_tools/Skyline/FileUI/ImportTransitionListColumnSelectDlg.cs

@@ -1345,14 +1345,7 @@ private bool CheckForErrors(bool silentSuccess, bool needsCheck)
                 }
                 catch (Exception exception)
                 {
-                    if (ExceptionUtil.IsProgrammingDefect(exception))
-                    {
-                        Program.ReportException(exception);
-                    }
-                    else
-                    {
-                        MessageDlg.ShowWithException(this, exception.Message, exception);
-                    }
+                    ExceptionUtil.DisplayOrReportException(this, exception);
                     Assume.IsTrue(errorCheckCanceled);
                 }
             }

pwiz_tools/Skyline/Properties/Resources.resx

@@ -13878,6 +13878,9 @@ If you choose Disable, you can enable Auto-select later with the "Refine > Ad
   <data name="Server_GetKey___anonymous_" xml:space="preserve">
     <value> (anonymous)</value>
   </data>
+  <data name="NodeTip_Timer_Tick_An_error_occurred_displaying_a_tooltip_" xml:space="preserve">
+    <value>An error occurred displaying a tooltip.</value>
+  </data>
   <data name="EncyclopeDiaHelpers_Generate_Waiting_for_chromatogram_library" xml:space="preserve">
     <value>Waiting for chromatogram library</value>
   </data>

pwiz_tools/Skyline/Util/Util.cs

@@ -31,6 +31,7 @@
 using System.Threading;
 using System.Windows.Forms;
 using pwiz.Common.SystemUtil;
+using pwiz.Skyline.Alerts;
 using pwiz.Skyline.FileUI;
 using pwiz.Skyline.Properties;
 using pwiz.Skyline.SettingsUI;
@@ -1920,6 +1921,8 @@ public static void WrapAndThrowException(Exception x)
                 throw new IOException(x.Message, x);
             if (x is OperationCanceledException)
                 throw new OperationCanceledException(x.Message, x);
+            if (x is UnauthorizedAccessException)
+                throw new UnauthorizedAccessException(x.Message, x);
             throw new TargetInvocationException(x.Message, x);            
         }
 
@@ -2127,6 +2130,31 @@ public static bool IsProgrammingDefect(Exception exception)
 
             return true;
         }
+
+        /// <summary>
+        /// Calls either <see cref="MessageDlg.ShowWithException"/> or <see cref="Program.ReportException"/> depending
+        /// on what <see cref="IsProgrammingDefect"/> returns.
+        /// <param name="parent">Parent window for message dialog</param>
+        /// <param name="exception">The exception that was caught</param>
+        /// <param name="message">Optional message which summarizes what Skyline was trying to do when the exception happened,
+        /// to be inserted on a separate line before the exception's message.</param>
+        /// </summary>
+        public static void DisplayOrReportException(IWin32Window parent, Exception exception, string message = null)
+        {
+            if (IsProgrammingDefect(exception))
+            {
+                Program.ReportException(exception);
+            }
+            else
+            {
+                string fullMessage = exception.Message;
+                if (string.IsNullOrEmpty(message))
+                {
+                    fullMessage = TextUtil.LineSeparate(message, fullMessage);
+                }
+                MessageDlg.ShowWithException(parent, fullMessage, exception);
+            }
+        }
     }
 
     public class Alarms