Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix an intermittent failure in TestDetectionsPlot #2781

Conversation

bspratt
Copy link
Member

@bspratt bspratt commented Nov 20, 2023

No description provided.

@nickshulman
Copy link
Contributor

I wonder if @rita-gwen has any ideas about how this could be fixed.
In theory that DetectionPlotData.GetDataCache().Status == DetectionPlotData.DetectionDataCache.CacheStatus.idle is supposed to wait until the cache has no more work to do, so it might be that something in there is not working the way that we would expect.

@bspratt
Copy link
Member Author

bspratt commented Nov 20, 2023

I wonder if @rita-gwen has any ideas about how this could be fixed. In theory that DetectionPlotData.GetDataCache().Status == DetectionPlotData.DetectionDataCache.CacheStatus.idle is supposed to wait until the cache has no more work to do, so it might be that something in there is not working the way that we would expect.

Yeah, I was thinking that we might be overrunning that - asking for its status before its even aware that there's work to be done

@bspratt bspratt merged commit 39caafa into master Dec 7, 2023
12 checks passed
@bspratt bspratt deleted the Skyline/work/20231120_attempt_fix_TestDetectionsPlot_race_condition branch December 7, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants