Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix an intermittent failure in TestDetectionsPlot #2781

Merged
merged 4 commits into from
Dec 7, 2023
Merged

attempt to fix an intermittent failure in TestDetectionsPlot #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60c34bd
attempt to fix an intermittent failure in TestDetectionsPlot
bspratt Nov 20, 2023
843b260
Merge branch 'master' into Skyline/work/20231120_attempt_fix_TestDete…
bspratt Nov 21, 2023
a2fede9
Merge branch 'master' into Skyline/work/20231120_attempt_fix_TestDete…
bspratt Dec 1, 2023
6c06219
Merge branch 'master' into Skyline/work/20231120_attempt_fix_TestDete…
nickshulman Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pwiz_tools/Skyline/Controls/Graphs/DetectionPlotData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ public class DetectionPlotData
public bool IsValid { get; private set; }
public int ReplicateCount { get; private set; }

public bool TryGetTargetData(DetectionsGraphController.TargetType target, out DataSet dataSet) // For test support
{
return _data.TryGetValue(target, out dataSet);
}

public DataSet GetTargetData(DetectionsGraphController.TargetType target)
{
return _data[target];
Expand Down
2 changes: 2 additions & 0 deletions pwiz_tools/Skyline/TestFunctional/DetectionsPlotTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ private void AssertDataCorrect(DetectionsPlotPane pane, int refIndex, float qVal
{
WaitForConditionUI(() => pane.CurrentData != null
&& pane.CurrentData.QValueCutoff == qValue
&& pane.CurrentData.TryGetTargetData(DetectionsGraphController.TargetType.PEPTIDE, out _)
&& pane.CurrentData.TryGetTargetData(DetectionsGraphController.TargetType.PRECURSOR, out _)
&& DetectionPlotData.GetDataCache().Status == DetectionPlotData.DetectionDataCache.CacheStatus.idle,
() => $"Retrieving data for qValue {qValue}, refIndex {refIndex} took too long.");
WaitForGraphs();
Expand Down