Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default Koina URL #3233

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Change default Koina URL #3233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ef9321
Change default Koina URL
chambm Nov 21, 2024
334b0bb
Reduce precision requirement for checking Koina peak intensities
chambm Nov 22, 2024
0cba6ac
Relax RT and intensity epsilon to 1e-2
chambm Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pwiz_tools/Skyline/Model/Koina/Config/KoinaConfig_development.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0"?>
<KoinaConfig xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<Server>koina.proteomicsdb.org:443</Server>
</KoinaConfig>
<Server>koina.wilhelmlab.org:443</Server>
</KoinaConfig>
4 changes: 2 additions & 2 deletions pwiz_tools/Skyline/TestConnected/KoinaBuildLibraryFromCsvTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ void comparePredictionResultsToFile(string intensityModel, string rtModel, bool
var expected = predictionTests.First(t => t.PeptideModSeq == key.ModifiedSequence);
Assert.AreEqual(expected.PrecursorMz, precursorMz, 1e-8, $"{testTag}: PrecursorMz not equal");
Assert.AreEqual(expected.PrecursorCharge, key.Charge, $"{testTag}: PrecursorCharge not equal");
Assert.AreEqual(expected.RetentionTime, spectrum.RetentionTime.Value, 1e-5, $"{testTag}: RetentionTime not equal");
Assert.AreEqual(expected.RetentionTime, spectrum.RetentionTime.Value, 1e-2, $"{testTag}: RetentionTime not equal");

if (!comparePeaks)
continue;
Expand All @@ -276,7 +276,7 @@ void comparePredictionResultsToFile(string intensityModel, string rtModel, bool
var expectedPeak = expected.Peaks[i];
var actualPeak = actualPeaks[i];
Assert.AreEqual(expectedPeak.Mz, actualPeak.Mz, 1e-5, $"{testTag}: peak[{i}].Mz not equal");
Assert.AreEqual(expectedPeak.Intensity, actualPeak.Intensity, 1e-5, $"{testTag}: peak[{i}].Intensity not equal");
Assert.AreEqual(expectedPeak.Intensity, actualPeak.Intensity, 1e-2, $"{testTag}: peak[{i}].Intensity not equal");
}
}
}
Expand Down