Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent properties like "SelectedResultsIndex" from showing up in the property sheet in "ViewMenu" form. #3322

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nickshulman
Copy link
Contributor

In the form designer for classes that are derived from "SkylineControl", such as "ViewMenu" or "EditMenu", some properties from the base class were showing up in the property sheet.

… property sheet in "ViewMenu" form.

In the form designer for classes that are derived from "SkylineControl", such as "ViewMenu" or "EditMenu", some properties from the base class were showing up in the property sheet.
@nickshulman nickshulman requested a review from ekoneil January 6, 2025 07:43
Copy link
Collaborator

@ekoneil ekoneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ModeUiHandler need the same attributes since it has a getter? Otherwise, lgtm. Thanks for the quick fix (and explanation in email).

@nickshulman
Copy link
Contributor Author

Does ModeUiHandler need the same attributes since it has a getter? Otherwise, lgtm. Thanks for the quick fix (and explanation in email).

Good point. We would prefer not to have that property show up in the Property Sheet either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants