Fix perftest skiplist after renaming #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… renamed (TODO: refactor TestRunner's test listing feature to avoid this potential source of error; e.g. skip ones with NoNightlyTesting attribute, or perhaps a new one like NoCITesting which would be more aggressive than NoNightly)
chambm
deleted the
Skyline/work/20250109_fix_perftest_skiplist_after_renaming
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed perftest skiplist after renaming (TODO: refactor TestRunner's test listing feature to avoid this potential source of error; e.g. skip ones with NoNightlyTesting attribute, or perhaps a new one like NoCITesting which would be more aggressive than NoNightly)
@brendanx67 This snuck in when you merged the rename PR #3312 without waiting for the nightly perftests to run. Until the above TODO is done, or we have enough TCA nodes to run Skyline perftests on each checkin, we should try to let PRs run overnight if the changes possibly affect the perftests or tutorials (or you can manually trigger the perftests config early if urgent).