Explore challenging intermittent nightly test failures - decrufted #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manda in-process causes memory corruption issues which can cause later tests to fail. The problem isn't seen on most machines, and isn't even consistent on the ones where it is (e.g. BSPRATT-UW2)
…ery use of SkylineWindow.OpenFile() is followed by WaitForDocumentLoaded as appropriate - mostly by using AbstractFunctionalTestEx.OpenDocument() instead of RunUI(() => SkylineWindow.OpenFile())
…s you do want release-style code with debug symbols retained
…tps://github.com/ProteoWizard/pwiz into Skyline/work/20250110_skip_MSAmanda_in_nightlies
…e command, which helps on unstable networks
…tps://github.com/ProteoWizard/pwiz into Skyline/work/20250110_skip_MSAmanda_in_nightlies
…tps://github.com/ProteoWizard/pwiz into Skyline/work/20250110_skip_MSAmanda_in_nightlies
…ng on to the next test, and write one more memory dump at the end of the overall test session.
… to see how much that fixes Eduardo's machine
…tps://github.com/ProteoWizard/pwiz into Skyline/work/20250110_skip_MSAmanda_in_nightlies
…number of requests to Uniporot servers for metadata resolution.
…k/20250110_skip_MSAmanda_in_nightlies
|
We need the perftests commit cherry picked into master ASAP please. Maybe release as well? |
You're referring to the most recent "Improve performance in the Unique Peptides perftests by reducing the number of requests to Uniporot servers for metadata resolution" change? |
|
Yes. And cherry pick to release as well. Nightlies are failing there too. |
|
OK I'll make a quick PR with just that change for cherry picking purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapping this in as Integration test branch as hopefully miminal change set for calming nightlies. Most significantly, it omits tests using MSAmanda as that seems to have effects on C++ memory stability.