Update localized resx files by reverting to English all strings that have changed since 24.1 #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickshulman
deleted the
Skyline/work/20250126_UpdateLocalizedResxFiles
branch
nickshulman
pushed a commit
that referenced
this pull request
Feb 9, 2025
The text "DIA raw (deconvolute, search, and build library)" changed to "DIA raw (search and build library)" For this reason, PR #3348 reverted these strings back to the English version until they can be re-localized.
nickshulman
added a commit
that referenced
this pull request
Feb 9, 2025
The text "DIA raw (deconvolute, search, and build library)" changed to "DIA raw (search and build library)" For this reason, PR #3348 reverted these strings back to the English version until they can be re-localized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request used the "pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer//IncrementalUpdateResxFiles" target in PR #3347 to update the Japanese and Chinese .resx files so that strings that have changed since 24.1 are reverted back to the English.
This fixes cases where the layout of a form has changed such as the way the "Instrument" tab on the Transition Settings looks in master right now:
versus the way that it looks in this pull request:
(in the first screenshot, the "Triggered chromatogram acquisition" checkbox is not visible because it is hidden behind the new "Advance filtering" text box)