Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tournament winner #274

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Add support for tournament winner #274

merged 2 commits into from
Oct 1, 2024

Conversation

starknetdev
Copy link
Member

@starknetdev starknetdev commented Oct 1, 2024

  • Add designs for blobert
  • Don't show dead adventurers by default
  • Add another payment button

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new environment variable NEXT_PUBLIC_TOURNAMENT_ENDED.
    • Added functionality to manage and utilize a new token type (blobertTokenId) across various components.
    • Implemented a new GraphQL query, getOwnerTokens, to fetch tokens owned by users.
  • Improvements

    • Enhanced state management and address validation in the AdventurersList component.
    • Improved payment processing in the Spawn component with new token handling.
  • Bug Fixes

    • Streamlined error handling during the minting process.
  • Chores

    • Cleaned up commented-out code in the clients module for better maintainability.

- add extra pay button
- hide dead adventurers by default
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
loot-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:05pm

Copy link

coderabbitai bot commented Oct 1, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple components and files. A new environment variable NEXT_PUBLIC_TOURNAMENT_ENDED is added to the .env file. Various components, including SpecialBeast, AdventurersList, CreateAdventurer, and Spawn, undergo reorganization of import statements and modifications to state management and props. The AdventurerScreen is updated to handle new token-related data, while new GraphQL queries are introduced, and some existing ones are removed. Additionally, the network configuration is enhanced with a new property for tournament winners.

Changes

File Path Change Summary
ui/.env Added new environment variable NEXT_PUBLIC_TOURNAMENT_ENDED with value "false".
ui/src/app/components/notifications/SpecialBeast.tsx Reorganized import statements; modified URL construction in fetchBeast within a useEffect hook.
ui/src/app/components/start/AdventurersList.tsx Reorganized imports; initialized showZeroHealth state to false; refined address validation logic.
ui/src/app/components/start/CreateAdventurer.tsx Reordered imports; added blobertsData prop to CreateAdventurerProps interface.
ui/src/app/components/start/Spawn.tsx Updated SpawnProps interface to include blobertTokenId and blobertsData; modified token management logic.
ui/src/app/containers/AdventurerScreen.tsx Updated AdventurerScreenProps interface to include blobertTokenId and blobertsData; integrated with CreateAdventurer.
ui/src/app/hooks/graphql/queries.ts Added new GraphQL query getOwnerTokens; removed several existing queries; reordered exports.
ui/src/app/lib/clients.ts Removed commented-out code related to authentication and HTTP link creation.
ui/src/app/lib/networkConfig.ts Added tournamentWinnerAddress property to networkConfig for multiple configurations.
ui/src/app/lib/utils/syscalls.ts Updated addApprovalCalls and spawn functions to include blobertTokenId; improved error handling in mintLords.
ui/src/app/page.tsx Added getOwnerTokens query; created gameClientInstance and blobertTokenVariables; integrated blobertsData.

Possibly related PRs

  • Dusky Client Improvements #268: Modifications to the .env file, specifically the addition of a new environment variable, which is directly related to the changes made in the main PR.
  • Payment QOL #273: Changes to the Spawn.tsx component, which may interact with the payment handling in the Spawn component, indicating a potential relationship between the two.

🐰 In the meadow where bunnies play,
A new variable brightens the day.
With tokens and props, we hop with glee,
Adventures await, come join us, you see!
From beasts to adventurers, all in a line,
Together we'll flourish, our spirits will shine! ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@starknetdev starknetdev merged commit ab8fe81 into main Oct 1, 2024
9 checks passed
@starknetdev starknetdev deleted the feat/tourney-winner branch October 7, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant