Implement changing adventurer name #276
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,12 @@ export interface AdventurerListProps { | |
| from: string, | ||
| recipient: string | ||
| ) => Promise<void>; | ||
| changeAdventurerName: ( | ||
| account: AccountInterface, | ||
| adventurerId: number, | ||
| name: string, | ||
| index: number | ||
| ) => Promise<void>; | ||
| } | ||
|
|
||
| export const AdventurersList = ({ | ||
|
|
@@ -51,6 +57,7 @@ export const AdventurersList = ({ | |
| adventurersCount, | ||
| aliveAdventurersCount, | ||
| transferAdventurer, | ||
| changeAdventurerName, | ||
| }: AdventurerListProps) => { | ||
| const { provider } = useProvider(); | ||
| const starknetIdNavigator = new StarknetIdNavigator( | ||
|
|
@@ -548,6 +555,8 @@ export const AdventurersList = ({ | |
| gameContract={gameContract} | ||
| handleSwitchAdventurer={handleSwitchAdventurer} | ||
| transferAdventurer={transferAdventurer} | ||
| changeAdventurerName={changeAdventurerName} | ||
|
There was a problem hiding this comment. 💡 Codebase verification
The
🔗 Analysis chainLGTM! Verify AdventurerListCard implementation. The To ensure the complete implementation of the name change functionality, let's verify the AdventurerListCard component: This script will help verify that the AdventurerListCard component properly implements the name change functionality. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the implementation of changeAdventurerName in AdventurerListCard
# Check if AdventurerListCard component uses the changeAdventurerName prop
echo "Checking AdventurerListCard implementation:"
rg --type typescript 'changeAdventurerName.*prop[s]?' ui/src/app/components/start/AdventurerListCard.tsx
# Check for any UI elements or functions related to changing the adventurer's name
echo "Checking for name change UI elements or functions:"
rg --type typescript 'change.*name|rename|updateName' ui/src/app/components/start/AdventurerListCard.tsx
Length of output: 491 Script: #!/bin/bash
# Description: Verify the implementation of changeAdventurerName in AdventurerListCard.tsx
# Locate the AdventurerListCard.tsx file
echo "Locating AdventurerListCard.tsx:"
ADVENTURER_FILE=$(fd 'AdventurerListCard\.tsx$' ui/src/app/components/start/)
if [ -z "$ADVENTURER_FILE" ]; then
echo "AdventurerListCard.tsx not found."
exit 1
fi
echo "Found: $ADVENTURER_FILE"
# Check if AdventurerListCard component uses the changeAdventurerName prop
echo "Checking for 'changeAdventurerName' prop usage in AdventurerListCard.tsx:"
rg 'changeAdventurerName\s*=' "$ADVENTURER_FILE"
# Check for any UI elements or functions related to changing the adventurer's name
echo "Checking for name change UI elements or functions in AdventurerListCard.tsx:"
rg 'change.*name|rename|updateName' "$ADVENTURER_FILE"
Length of output: 892 Script: #!/bin/bash
# Description: Comprehensive search for 'changeAdventurerName' usage across the codebase
# Search for 'changeAdventurerName' in all .tsx and .ts files
echo "Searching for 'changeAdventurerName' across the entire codebase:"
rg 'changeAdventurerName' --type-add 'typescript:*.ts,*.tsx' --typescript
Length of output: 655 Script: #!/bin/bash
# Description: Comprehensive search for 'changeAdventurerName' usage across the codebase
# Search for 'changeAdventurerName' in all .ts and .tsx files without using --type flag
echo "Searching for 'changeAdventurerName' in .ts and .tsx files across the codebase:"
rg 'changeAdventurerName' -g '*.ts' -g '*.tsx'
Length of output: 1220 |
||
| index={selectedIndex} | ||
| /> | ||
| )} | ||
| </div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,12 @@ interface AdventurerScreenProps { | |
| from: string, | ||
| recipient: string | ||
| ) => Promise<void>; | ||
| changeAdventurerName: ( | ||
| account: AccountInterface, | ||
| adventurerId: number, | ||
| name: string, | ||
| index: number | ||
| ) => Promise<void>; | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -50,6 +56,7 @@ export default function AdventurerScreen({ | |
| getBalances, | ||
| costToPlay, | ||
| transferAdventurer, | ||
| changeAdventurerName, | ||
| }: AdventurerScreenProps) { | ||
| const [activeMenu, setActiveMenu] = useState(0); | ||
| const setAdventurer = useAdventurerStore((state) => state.setAdventurer); | ||
|
|
@@ -152,6 +159,7 @@ export default function AdventurerScreen({ | |
| adventurersCount={adventurersByOwnerCount} | ||
| aliveAdventurersCount={aliveAdventurersByOwnerCount} | ||
| transferAdventurer={transferAdventurer} | ||
| changeAdventurerName={changeAdventurerName} | ||
| /> | ||
| </div> | ||
| )} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,9 +40,7 @@ export const getWaitRetryInterval = (network: string) => | |
| export const ETH_INCREMENT = 0.001; | ||
| export const LORDS_INCREMENT = 5; | ||
| export const getMaxFee = (network: string) => | ||
| network === "mainnet" ? 0.001 * 10 ** 18 : 0.3 * 10 ** 18; // 0.3ETH on mainnet or sepolia, 0.0003ETH on goerli | ||
|
There was a problem hiding this comment. 💡 Codebase verification Inconsistency Detected Between The Please address the following:
🔗 Analysis chainSignificant changes to The modification to the
Please address the following:
To ensure this change doesn't affect other parts of the codebase, please run the following script: This will help identify any other locations where the 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for usages of getMaxFee function
rg "getMaxFee" --type typescript
Length of output: 67 Script: #!/bin/bash
# Search for usages of getMaxFee function in .ts files
rg "getMaxFee" --glob "*.ts"
Length of output: 536 |
||
| export const ETH_PREFUND_AMOUNT = (network: string) => | ||
| network === "mainnet" || network === "sepolia" | ||
| ? "0x2386F26FC10000" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Include
timestampwhen updating adventurer name for consistencyConsistently including a
timestampin update operations helps maintain a uniform data structure and aids in tracking changes over time. Consider adding atimestampfield to theupdateAdventurerNamefunction call.Suggested change:
return [ updateAdventurerName({ adventurerId: value.adventurerId, adventurerName: value.name, + timestamp: new Date().toISOString(), }), ];📝 Committable suggestion