Fix UI to ensure random button on scalar mul works + ensure multiplic…

…ative inverse work without a second field element loaded
ProvableHQ · Jan 27, 2025 · f2c73e8 · f2c73e8
1 parent d89181c
commit f2c73e8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/website/src/tabs/algebra/FieldArithmetic.jsx b/website/src/tabs/algebra/FieldArithmetic.jsx
@@ -47,8 +47,8 @@ export const FieldArithmetic = () => {
     };
 
     const calculateResult = (num1, num2, op) => {
-        if ((op === "inv" && num1 === "") || 
-            (op !== "inv" && (num1 === "" || num2 === ""))) {
+        if (((op === "inv" || op === "mulinv") && num1 === "") ||
+            ((op !== "inv" && op !== "mulinv") && (num1 === "" || num2 === ""))) {
             setResult("");
             return;
         }

diff --git a/website/src/tabs/algebra/GroupArithmetic.jsx b/website/src/tabs/algebra/GroupArithmetic.jsx
@@ -152,6 +152,12 @@ export const GroupArithmetic = () => {
         calculateResult(groupValueOne, newValue, operation);
     };
 
+    const onScalarRandom = () => {
+        const newValue = generateRandomScalar();
+        setScalarValue(newValue);
+        calculateResult(groupValueOne, groupValueTwo, operation, newValue);
+    }
+
     const layout = { 
         labelCol: { span: 6 }, 
         wrapperCol: { span: 18 },
@@ -264,7 +270,7 @@ export const GroupArithmetic = () => {
                             />
                             <Button 
                                 size="large"
-                                onClick={() => setScalarValue(generateRandomScalar())}
+                                onClick={onScalarRandom}
                                 style={{ width: '110px' }}
                             >
                                 Random