-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Execute options object refactor #811
Conversation
…licTransaction, unbondPublic, buildClaimUnbondPublicTransaction, claimUnbondPublic options object refactors
I like the options refactors, I have a few minor nits, but I'd say we're okay to just proceed refactoring the rest of the methods in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…jects-option-refactor # Conflicts: # sdk/src/program-manager.ts
@iamalwaysuncomfortable resolved conflicts and updated docs if you want to just double check I resolved the intent of your changes correctly. |
…jects-option-refactor # Conflicts: # website/src/workers/worker.js
Motivation
Moves params for
execute
into anExecutionOptions
object and interface. This will minimize breaking changes should execute be modified in the future and also makes usage a bit easier as you don't have to pass inundefined
to reach other optional params.buildExecutionTransaction, buildBondPublicTransaction, buildUnbondPublicTransaction, unbondPublic, buildClaimUnbondPublicTransaction, claimUnbondPublic, setValidatorState
andunbondDelegatorAsValidator
updated as well to unify into singleExecutionOptions
interface and flow.Would like to do this with most functions (especially
run
) but wanted to get opinions on approach before refactor becomes too big. @Pauan @iamalwaysuncomfortableExample Old
Example New
Test Plan
Should ideally work the same as the previous execute, params just passed in as object now.