Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in new X-Aleo-SDK-Version header #876

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

Pauan
Copy link
Collaborator

@Pauan Pauan commented Apr 8, 2024

When the SDK makes a request to the server, this automatically adds in an X-Aleo-SDK-Version header, so the server can identify whether the request came from the SDK or not.

Fixes https://github.com/AleoHQ/explorer-monorepo/issues/14

@Pauan
Copy link
Collaborator Author

Pauan commented Apr 8, 2024

There are a few things that must be done before this is merged:

  • The Wasm functions should also send the header
  • The header should be customizable for ProgramManager
  • Add in unit tests
  • Somehow make the version not hardcoded

@Pauan Pauan marked this pull request as ready for review April 22, 2024 01:38
@Pauan
Copy link
Collaborator Author

Pauan commented Apr 22, 2024

This is now ready for review:

  • The Wasm functions call SnarkVM functions, so that can't be fixed in this PR.
  • Making the header customizable is a breaking change that must be done in a different PR.
  • I added in unit tests.
  • The version is no longer hardcoded.

@Pauan Pauan merged commit 2781e07 into ProvableHQ:testnet3 May 15, 2024
9 checks passed
@Pauan Pauan deleted the feat/header branch May 15, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants