Prevent hypothetical overflow #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
approved these changes
Nov 24, 2023
|
Moving back to draft, as CI is failing |
vicsn
force-pushed
the
prevent_addition_overflow_srs
branch
from
dd94cf4 to
aedbb05
Compare
vicsn
force-pushed
the
prevent_addition_overflow_srs
branch
from
aedbb05 to
07b7f08
Compare
|
Fixed the broken test. The two CI tests which are still failing are unrelated to this PR and succeed locally. Perhaps because reduce_pk_size_3 (which this merges into) requires resampling |
howardwu
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes https://github.com/AleoHQ/snarkVM/issues/2166
Note that with our current stack we would have never hit these cases. But they could be a hypothetical concern when we support delegated proving and someone wants to DoS the party willing to do the proving.