Fixed tvOS 13 and 14 crashes and also fixed and tested AirDrop support for nitoTV. #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds for this Pull Request are available at |
added 2 commits
June 29, 2023 01:18
…Introspect to fix one of the tvOS 13 crashes. Made minor changes to fix AirDrop in nitoTV.
|
Builds for this Pull Request are available at |
JoeMatt
added
the
needs cleaning
JoeMatt
added a commit
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Joseph Mattello <[email protected]>
|
closing in favor of #2280 since history got weird and some of the change aren't needed anymore
|
JoeMatt
added a commit
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Joseph Mattello <[email protected]>
JoeMatt
added a commit
that referenced
this pull request
Jan 10, 2024
Signed-off-by: Joseph Mattello <[email protected]>
JoeMatt
added a commit
that referenced
this pull request
Jan 14, 2024
Signed-off-by: Joseph Mattello <[email protected]>
JoeMatt
added a commit
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Joseph Mattello <[email protected]>
JoeMatt
added a commit
that referenced
this pull request
Jan 18, 2024
Signed-off-by: Joseph Mattello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
tvOS 13 and 14 were crashing for a few different reasons, the minimum build target was missing for the fceux libraries that was causing weird missing symbol issues for libstdc++. For tvOS 13 it was crashing because of improperly gated iOS specific code in SwiftUI-Introspect. It wouldn't attempt to add or use the code but it would still create a reference to the UIColorWell symbol (which does exist in tvOS, its just unavailable). That doesn't exist at all in tvOS 13 so it would cause an exception.
for the nitoTV AirDrop code we need to use path related copying methods rather than URL because the URL based one's error out with this message:
The file couldn’t be opened because the specified URL type isn’t supported.And before that error message occurs this one is printed out in os_log:
CFURLCopyResourcePropertyForKey failed because it was passed an URL which has no schemethis should also address the bug: #2167
Where should the reviewer start
How should this be manually tested
Any background context you want to provide
What are the relevant tickets
Screenshots (important for UI changes)
Questions