Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllowMultiplePlatforms=1 various cores,frameworks, pre app store prep #2278

Closed
wants to merge 34 commits into from
Closed

AllowMultiplePlatforms=1 various cores,frameworks, pre app store prep #2278

wants to merge 34 commits into from

Conversation

JoeMatt
Copy link
Member

@JoeMatt JoeMatt commented Jan 9, 2024 •
edited
Loading

Set "AllowMultiplePlatforms" to some targets that weren't enabled.

TODO:

  • How does this feature work?
  • Is every target setup correctly for it
  • TVOS Fix these errors;
❌  /Users/runner/work/Provenance/Provenance/Provenance/NewUI/Consoles/ConsoleGamesView.swift:127:22: 'MagnificationGesture' is unavailable in tvOS

            .gesture(MagnificationGesture()
           ~~~~^~~~~~~     ~~~
❌  /Users/runner/work/Provenance/Provenance/Provenance/NewUI/Consoles/ConsoleGamesView.swift:296:33: 'orientation' is unavailable in tvOS

            if UIDevice.current.orientation.isLandscape
              ^
❌  /Users/runner/work/Provenance/Provenance/Provenance/NewUI/Consoles/ConsoleGamesView.swift:296:45: 'isLandscape' is unavailable in tvOS

            if UIDevice.current.orientation.isLandscape
             ^
❌  /Users/runner/work/Provenance/Provenance/Provenance/NewUI/Consoles/ConsoleGamesView.swift:307:33: 'orientation' is unavailable in tvOS

            if UIDevice.current.orientation.isLandscape
               ^
❌  /Users/runner/work/Provenance/Provenance/Provenance/NewUI/Consoles/ConsoleGamesView.swift:307:45: 'isLandscape' is unavailable in tvOS

            if UIDevice.current.orientation.isLandscape
             ^

@JoeMatt JoeMatt added dev implementation, code, development WIP labels Jan 9, 2024
@JoeMatt JoeMatt self-assigned this Jan 9, 2024
@JoeMatt JoeMatt requested a review from jasarien as a code owner January 9, 2024 20:54
@JoeMatt JoeMatt marked this pull request as draft January 9, 2024 21:53
@github-actions GitHub Actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
Provenance-Lite.ipa
ProvenanceTV.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@JoeMatt JoeMatt force-pushed the feature/MultiPlatformTargets branch from be8a76f to 2a04293 Compare January 14, 2024 02:36
@JoeMatt JoeMatt force-pushed the feature/MultiPlatformTargets branch from 2a04293 to b45faf6 Compare April 2, 2024 19:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Builds for this Pull Request are available at
Provenance.ipa
Provenance-Lite.ipa
ProvenanceTV.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@JoeMatt JoeMatt force-pushed the feature/MultiPlatformTargets branch 2 times, most recently from 7afe60d to bec9bb6 Compare April 9, 2024 05:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Builds for this Pull Request are available at
Provenance.ipa
Provenance-Lite.ipa
ProvenanceTV.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@JoeMatt JoeMatt force-pushed the feature/MultiPlatformTargets branch 7 times, most recently from c2581fb to ebaecaa Compare April 28, 2024 16:16
@JoeMatt JoeMatt changed the title [WIP] AllowMultiplePlatforms=1 various cores,frameworks AllowMultiplePlatforms=1 various cores,frameworks, pre app store prep Apr 28, 2024
@JoeMatt
Copy link
Member Author

JoeMatt commented Apr 28, 2024

Just for note, this PR basically also became the Pre App Store quick fixes branch for play and dolphin.

@JoeMatt JoeMatt marked this pull request as ready for review April 28, 2024 17:58
@JoeMatt JoeMatt modified the milestones: v2.3.x / Later…, 2.3.0 Apr 28, 2024
JoeMatt added 27 commits April 29, 2024 02:18
@JoeMatt
gitignore flycast build dir
7ed3d97 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
crab emu mutli target
68118b1 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
virtualjaguar update for warnings
139b7e9 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
play update submodules
3484487 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
Play! Add BUILDING.md instructions for building
469a9ed 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
play CMAKE update script updated
6ead420 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
Play project updates post update.sh
46155b2 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
Play! project update for updated upstream
03c3f5e 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
play! update submodule
72050ee 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
play! xcode touched project
56988d6 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
play! playcore.mm controls api update
53f7a6f 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
play! cmake auto created files updated
75e4d93 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
visionOS force SwiftUI
38ba82e 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
spm update
48fec0a 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
bliss core minor project file updates
f5f3afa 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
play! xcodeproj xcode touched some things bcs xc
973df71 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
Play! tvOS patch around missing apis
f15b8ab 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
play! update submodule for Prov tvOS ifdefs
f394115 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
dolphin cmake script and readme updates
deacfc8 
better flags for smaller build with less stuff we’re not using

Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
dolphin reformat update.sh markdown.md
a43ae03 
reduced build complexity, less options turned on

Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
dolphin update.sh and readme updates
799c94f 
Script should work with newer and current slightly older dolphiniOS cmake builds

Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
dolphin oragnize xcconfig
c0bcf6f 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
dolphin fix tvOS missing touch UI call
c965a5e 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
Dolphin copy cmake toolchain file locally
139dc4b 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
dolphin add xcconfig just for generated dolphin project
2c4424b 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
dolphin fix builds, plus fixed simulator a64only
60454a0 
intel simulator doens’t run because there are flags that are hardwired into the generated cmake xcode project for arm64.

i made a quick and dirty fix to get it to build for arm simulator at least but intel builds will fail (we probably don’t have intel vulkan anyway so whatever)

Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
dolphin fix device builds from sim fix
8282163 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt JoeMatt force-pushed the feature/MultiPlatformTargets branch from 0fde198 to 8282163 Compare April 29, 2024 06:18
@JoeMatt
Copy link
Member Author

JoeMatt commented May 5, 2024

closed by #2333

@JoeMatt JoeMatt closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasarien jasarien Awaiting requested review from jasarien jasarien is a code owner

Assignees

@JoeMatt JoeMatt

Labels
dev implementation, code, development WIP
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@JoeMatt