Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qubo meta solver #50

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Add qubo meta solver #50

merged 7 commits into from
Jan 2, 2024

Conversation

Elscrux
Copy link
Member

@Elscrux Elscrux commented Sep 28, 2023

Including solver using Qiskit, and a QAOA based approach

@Elscrux Elscrux requested a review from schweikart September 28, 2023 15:21
Copy link
Member

@schweikart schweikart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things

@schweikart
Copy link
Member

Thanks for these changes @Elscrux! Can you add JavaDocs to the QuboSolver base class too? Then this is ready to be merged :)

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Elscrux Elscrux requested a review from schweikart November 9, 2023 14:09
@schweikart schweikart force-pushed the feature/qubo branch 2 times, most recently from 77910ae to d625b0b Compare January 2, 2024 14:58
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@schweikart
Copy link
Member

Had to rebase due to a conflict in qiskit/requirements.txt

Copy link
Member

@schweikart schweikart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schweikart schweikart merged commit f8782be into develop Jan 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants