Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUBO via PlanQK #63

Merged
merged 14 commits into from
Feb 3, 2025
Merged

QUBO via PlanQK #63

merged 14 commits into from
Feb 3, 2025

Conversation

Elscrux
Copy link
Member

@Elscrux Elscrux commented Dec 20, 2023

Closes #62

Currently, the QUBO format is using LP, which we parse using a forked library with some tweaks. The Quantagonia implementation needs a QUBO matrix so there are some more steps involved to create this out of the LP format. Note that the LP format is currently required to name its variables like this x0, x1, x2...

@Elscrux Elscrux requested a review from schweikart December 20, 2023 23:50
@schweikart
Copy link
Member

Can you rebase this to develop @Elscrux?

@Elscrux Elscrux force-pushed the feature/qubo-planqk branch from 3b98e9b to cbc5caf Compare January 16, 2024 10:01
@Elscrux
Copy link
Member Author

Elscrux commented Jan 16, 2024

Can you rebase this to develop @Elscrux?

@schweikart Done now. Sorry, I failed to see this earlier!

@Elscrux Elscrux force-pushed the feature/qubo-planqk branch from cbc5caf to a48f132 Compare January 16, 2024 11:14
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

29 New issues
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@schweikart
Copy link
Member

This PR adds a few changes to our internal interfaces which contradict #69. As discussed in our last meetings, we'll rebase and merge this once #69 is complete

@koalamitice koalamitice mentioned this pull request Oct 11, 2024
@Elscrux Elscrux force-pushed the feature/qubo-planqk branch 4 times, most recently from f74d0f0 to 16b59f5 Compare November 25, 2024 20:06
@Elscrux Elscrux requested review from koalamitice and removed request for schweikart November 27, 2024 19:16
@Elscrux Elscrux changed the title Quantagonia QUBO via PlanQK QUBO via PlanQK Dec 12, 2024
@Elscrux
Copy link
Member Author

Elscrux commented Dec 29, 2024

@koalamitice I think this is good to go now. Don't mind the duplicated code (or if you have a good idea how to reduce it properly let me know).

@Elscrux Elscrux force-pushed the feature/qubo-planqk branch from 42f2b02 to 13abdee Compare January 27, 2025 09:12
@koalamitice koalamitice merged commit 5a6c3c9 into develop Feb 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlanQK QUBO Solver
3 participants