Fix crash when download large file #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid memory consumes in app when download large file that causing crash app
NghiaTranUIT
requested changes
Apr 10, 2022
Sources/Transporter.swift
Outdated
| @@ -48,7 +48,7 @@ final class NetServiceTransport: NSObject { | |||
| // For some reason, Stream Task could send a big file | |||
| // https://github.com/ProxymanApp/atlantis/issues/57 | |||
| static let MaximumSizePackage = 52428800 // 50Mb | |||
|
|
|||
| static let MaximumSizeResponse = 2097152 // 2MB | |||
There was a problem hiding this comment.
I suppose that we should increase the MaximumSizeResponse to 5Mb or 10Mb. 2Mb is likely too small.
There was a problem hiding this comment.
Yeah, It likely too small, I'm fixing to 10 MB and you can check it.
Thank you
Update Maximum File Size Response to 10 MB Co-Authored-By: Nghia Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid memory consuming in app when download large file that causing crash app
