Detect invalid TShock installations #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drunderscore
force-pushed
the
feature/detect-installations-in-client-directory
branch
from
d1ebbd6 to
a86f18c
Compare
|
Thanks! You've saved @CEO-Chair's bacon! |
Arthri
reviewed
Dec 21, 2022
drunderscore
force-pushed
the
feature/detect-installations-in-client-directory
branch
from
a86f18c to
7eccd72
Compare
There are two common mistakes made by those installing/updating TShock: - Extracting TShock into the Terraria client directory - Extracting TShock 5 or newer into a legacy (TShock 4 or older) install By checking for the existence of a file named `TerrariaServer.exe`, we can potentially detect these invalid installations, and prompt the user with a more useful diagnostic, rather than (likely) crashing moments later.
drunderscore
force-pushed
the
feature/detect-installations-in-client-directory
branch
from
7eccd72 to
3776baa
Compare
drunderscore
changed the title
Arthri
reviewed
Dec 21, 2022
| // On occasion, users have been seen extracting TShock into their client installation directory -- this is of course incorrect, and is known | ||
| // to cause issues. Let's attempt to catch this before anything happens (specifically, before Terraria assemblies are resolved) and prevent | ||
| // TShock from launching. | ||
| if (File.Exists("TerrariaServer.exe")) |
There was a problem hiding this comment.
😅 I forgot to mention the .exe part is windows-specific. should it take into account other OSes?
There was a problem hiding this comment.
No, the exe part is not windows-specific, it also exists on Linux... and I'd assume Mac
There was a problem hiding this comment.
At least vanilla and TShock 4 are both using Mono - and they are just regular assembly and extension doesn't matters much. This doesn't work for tModLoader, but who would do that tho?
|
I think I would check for Content instead of a platform-specific binary, personally. But I'd check for something inside Content too? |
hakusaro
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar introduced in this PR is meant to be nit-picked! Please suggest what sounds most natural and understandable to an end-user.
Additionally, because we are in TShockLauncher and not in TShock yet, we cannot translate strings... and an error like this would benefit greatly from such. It may be worthwhile to hardcode some translations?