NetItem changes #2945
Open
NetItem changes #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method will create a Terraria.Item instance based on the data from the structure.
Arthri
reviewed
Jun 6, 2023
Arthri
previously approved these changes
Jun 7, 2023
punchready
suggested changes
Jun 8, 2023
docs/changelog.md
Outdated
| Your changes could be here! | ||
| * Updated `TShockAPI.NetItem` (@AgaSpace): | ||
| * Added constructor overload with parameter `Terraria.Item`. | ||
| * Added the `Build` method to get a copy of `Terraria.Item`. |
There was a problem hiding this comment.
Needs to be updated to ToItem
TShockAPI/NetItem.cs
Outdated
| public Item ToItem() | ||
| { | ||
| if (_netId == 0) | ||
| throw new Exception("It is impossible to create an item whose ID is 0."); |
There was a problem hiding this comment.
That is not true, and this method should allow creating an empty item in my opinion, in case that is useful to some plugins.
Arthri
previously approved these changes
Jun 8, 2023
punchready
approved these changes
Jun 8, 2023
Arthri
previously approved these changes
Jun 8, 2023
Arthri
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to get from NetItem to TerrariaItem.
Added the ability to get NetItem from TerrariaItem.
Added optional parameters to the NetItem constructor (stack, prefix).