Lib change and prep for duplex #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have restructured the code into a more maintainable state. I think it's also a bit easier to read and know where things are.
The main reason for this was to support the
ont-pybasecall-client-liblibrary name change. Buttery-eel will detect which lib calls to use based on which library loads, preferencing the new library name over the old one in load order.I have also added in some new read and basecalling methods for duplex calling. These currently DO NOT WORK. Mostly because I am waiting for ONT to add in some missing features they left out of the python lib compared to the C++ lib, and the duplex matching methods are crazy inefficient. Do not use
--duplex. I will have a 0.5.0 release for when that is working.This PR fixes some issues with demultiplexing, namely the parent ID and read ID not working properly on split reads. This was than hampering the ability to dmux the slow5 files afterward.