-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Dynamic canister #24
Open
qti3e
wants to merge
9
commits into
Psychedelic:main
Choose a base branch
from
qti3e:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WASM this allows a canister to import another canister as crate without re-implementing that canister
…WASM this allows a canister to import another canister as crate without re-implementing that canister
but also add +lib, so we can import
Hi @qti3e, Any movement on this? Eagerly awaiting this release ❤️ |
@saikatdas0790 been caught up with some higher priorities recently, will get back to this feature this weekend. xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the management canister with a custom
ic_kit_install
method. The final result should be having the ability to dynamically install typed canisters both in the kit-runtime and to make it work in the IC env as well.And a factory canister should now be able to deploy this canister on the fly by doing:
The install_code implementation should use different targets
#[cfg(not(target_family = "wasm"))]
and#[cfg(target_family = "wasm")]
to perform platform specific calls to the management canister.