Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for #15 #57

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Workaround for #15 #57

merged 3 commits into from
Jan 23, 2025

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Jan 16, 2025

Fixes #15

When we detect Sex = "All" in the filters it now defaults to using SQL, this PR is dependent on #54

@Moohan Moohan requested a review from csillasch January 16, 2025 13:17
csillasch
csillasch previously approved these changes Jan 16, 2025
Base automatically changed from feature/multiple_filtering to master January 21, 2025 11:47
@Moohan Moohan dismissed csillasch’s stale review January 21, 2025 11:47

The base branch was changed.

@Moohan Moohan force-pushed the bug/sex_all_filter branch from 7258def to 710e88f Compare January 21, 2025 11:48
@Moohan Moohan force-pushed the bug/sex_all_filter branch from 710e88f to e4b6bfb Compare January 21, 2025 11:51
@Moohan Moohan enabled auto-merge January 21, 2025 11:53
@Moohan Moohan requested a review from csillasch January 21, 2025 13:13
@csillasch
Copy link
Contributor

The fix works great!
I noticed testing it on "83b38aa6-73c0-4489-b344-11081e7aa0ed" it does introduce slightly different behaviour when the filtering results in 0 matching rows - rather than returning a tibble with 0 rows it throws the error "Can't subset columns that don't exist.". Possibly just something to note in the docs or do you think worth including a warning / improving the error message?

@Moohan
Copy link
Member Author

Moohan commented Jan 23, 2025

The fix works great! I noticed testing it on "83b38aa6-73c0-4489-b344-11081e7aa0ed" it does introduce slightly different behaviour when the filtering results in 0 matching rows - rather than returning a tibble with 0 rows it throws the error "Can't subset columns that don't exist.". Possibly just something to note in the docs or do you think worth including a warning / improving the error message?

This should be fixed now - If the query returns no results it will just return an empty tibble.

@Moohan Moohan merged commit 016aeed into master Jan 23, 2025
16 checks passed
@csillasch csillasch deleted the bug/sex_all_filter branch January 23, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

row_filters doesn't work in an odd scenario
2 participants