Handle player packet id 0x23 #163
Conversation
| mc-source-code/DecompilerMC/ | ||
| mc-source-code/src/ | ||
| mc-source-code/target/ | ||
| mc-source-code/ |
There was a problem hiding this comment.
Why you modified the .gitignore ?
There was a problem hiding this comment.
Sorry I've used the "decompile.sh" file and that folder for save researches, to prevent any accidental upload I've changed to include any file and subfolder
| let mut abilities = self.abilities.lock().await; | ||
|
|
||
| // Set the flying ability | ||
| abilities.flying = player_abilities.flags & 0x02 != 0 && abilities.allow_flying; |
There was a problem hiding this comment.
The abilities have allow_flying as well, Should should set them and not check if they true in the packet
There was a problem hiding this comment.
I've seen that this packet is sent by the client only when the player starts/stops flying and is not sending the allow_flying property. I've implemented the same check that vanilla does (bit mask 0x02 on the Flags field of the packed and the additional check on the player allow_flying flag) to set the flying property
There was a problem hiding this comment.
Oh, Just looked at vanilla code and your right!, nvm then
|
Looks good then. |
Fix for:
Using the protocol packet: https://wiki.vg/Protocol#Player_Abilities_.28serverbound.29