[DRAFT] Bootloader Upgrade #14
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on eileen/bootloader firmware branch Also daqapp UI BL is broken because of API changes Signed-off-by: Eileen Yoon <[email protected]>
Canable firmware with gs_usb backend has a bug with high bus loads due to finite queue size. Solve by using native linux sockets instead Signed-off-by: Eileen Yoon <[email protected]>
Signed-off-by: Eileen Yoon <[email protected]>
There was a problem hiding this comment.
It's been a while so I might have forgotten a bit about why you made this file, but iirc it was because we weren't acking packets we sent on the RX line. If this is the only issue that prompted the creation of this file, I'd rather fix the underlying daqapp problem in communication/can_bus.py rather than bring bootloader out into it's own module. Boothloader isn't the only thing that is sending to the car thru DAQ
There was a problem hiding this comment.
Also would rather this be bootloader.py, full name is very helpful for understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add standalone BL module bl.py
Depends on eileen/bootloader firmware branch
Breaks daqapp UI BL button due to API changes