Kaminari pagination default view #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshinaan
reviewed
Jan 11, 2024
Gemfile
Outdated
| @@ -6,6 +6,8 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" } | |||
| # Specify your gem's dependencies in tramway.gemspec. | |||
| gemspec | |||
|
|
|||
| gem 'anyway_config' | |||
|
|
|||
There was a problem hiding this comment.
why you need empty lines in gemfile?
There was a problem hiding this comment.
No need, you are right! Removed 🙂
moshinaan
reviewed
Jan 11, 2024
lib/tramway/engine.rb
Outdated
| # :reek:NestedIterators { enabled: false } | ||
| # :reek:TooManyStatements { enabled: false } | ||
| def configure_pagination | ||
| ActiveSupport.on_load(:action_controller) do |_| |
There was a problem hiding this comment.
Suggested change
| ActiveSupport.on_load(:action_controller) do |_| | |
| ActiveSupport.on_load(:action_controller) do |
moshinaan
reviewed
Jan 11, 2024
| %nav.pagination.flex.items-center.justify-center.space-x-1 | ||
| = first_page_tag unless current_page.first? | ||
| = prev_page_tag unless current_page.first? | ||
| - each_page do |page| |
There was a problem hiding this comment.
maybe its better empty line before and after each. just to make the code easier to read
There was a problem hiding this comment.
There is no such empty lines in default kaminari views, so I think we don't need them either 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed basically?
This update is not supposed to set the default pagination behavior of applications, just setting views for kaminari.
EngineclassAbout dummy application views.
I have a plan to use these views as Tramway default views. That's dummy application views are already Tailwind-styled.
What's changed for tramway drivers?
To use tailwind-styled pagination
Gemfile
config/initializers/tramway.rb
app/views/users/index.html.haml
= paginate @users # it will render tailwind-styled pagination buttons by defaultPagination buttons look like this
Song for code review
It's Pentatonix this time. I know that one track is enough for the code review, so I'll prepare a little playlist next time 🙂
https://youtu.be/ywYfMlyIkeo?si=jo7rUFGw6aZzB-Kh