-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of Stimulus change
action for Tramway Multiselect
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshinaan
reviewed
Dec 10, 2024
def on_change | ||
return unless external_action&.start_with?('change') | ||
|
||
external_action.split('->').last |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have potential bugs with using .last
? not so clear as for me
This reverts commit 971c950.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed basically?
change
action for Tramway MultiselectWhat's changed for tramway drivers?
Before
IT DIDN'T WORK
After
Now! It works!
AI Generated description for this PR
This pull request includes several updates to the
Gemfile
, JavaScript multiselect controller, form components, and tests. The changes enhance functionality, improve integration with Stimulus controllers, and update tests for better coverage.Gemfile updates:
sqlite3
to thedevelopment
group.development, :test
group with thedebug
gem.JavaScript multiselect controller enhancements:
onChange
attribute to theMultiselect
controller.onChange
event handling to call specified Stimulus controller actions.Form component updates:
multiselect
method to handle the full value array instead of just the first element.multiselect_component
to includeon_change
and handle external actions. [1] [2]Stimulus controller integration:
index.js
to initialize Stimulus application and register controllers.UserForm
Stimulus controller with aconnect
method and anupdateForm
action.Test updates:
multiselect_input_spec.rb
to include setup steps in abefore
block and added a new scenario to test theonchange
Stimulus action. [1] [2] [3] [4] [5]