refactor: remove importlib-metadata fallback
#1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.7 support has been removed in PyCQA#1034, so the `importlib-metadata` fallback, is no longer required, as it was only need for Python < 3.8.
mkniewallner
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
|
Given the breaking changes in the standard library between 3.9 and 3.10 (if I'm remembering my versions correctly) we should probably keep the third party backport just in case 3.12 or newer cause similar problems |
Unless I'm missing something, the only place where the fallback is used is here. Since we first try to import from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7 support has been removed in
#1034, so the
importlib-metadatafallback, is no longer required, as it was only need for Python < 3.8.