Args parsing priority changed

[ZenSecurity]

ini file goes first, if it's empty, then command-line arguments passed.

[ZenSecurity]

After your last MR, arguments from file are not taken (c6b1302)
My small patch fixes this.

What do you think?

[ericwb]

Why is the order of preference being changed? Command line arguments almost always have highest priority, followed by environment variable, then config.

[ZenSecurity]

I changed the order because currently "--ini INI_PATH" option is not working anymore with your latest change.
https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L225 (takes default values)
https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L311 (passes default values)
https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L82 (breaks "--ini" parameter logic here)
Do you have any suggestions?

[ericwb]

I changed the order because currently "--ini INI_PATH" option is not working anymore with your latest change.
https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L225 (takes default values)
https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L311 (passes default values)
https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L82 (breaks "--ini" parameter logic here)
Do you have any suggestions?

Yeah, we need to fix or revert my patch if it's now breaking existing function.