Set up mypy #482
Merged
Set up mypy #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is minimal for now (didn't add any annotations, didn't turn on strict mode), just so we can get started. In later PRs I can add more strictness.
JelleZijlstra
commented
Jul 2, 2024
| b902_classmethod_decorators = attr.ib(factory=set) | ||
| node_window = attr.ib(factory=list) | ||
| errors = attr.ib(factory=list) | ||
| futures = attr.ib(factory=set) |
There was a problem hiding this comment.
This was unused
| @@ -657,10 +656,6 @@ def check_for_b005(self, node): | |||
| ): | |||
| return # used arguments don't match the builtin strip | |||
|
|
|||
| call_path = ".".join(compose_call_path(node.func.value)) | |||
| if call_path in B005.valid_paths: | |||
There was a problem hiding this comment.
This was empty and I'm not sure what it was meant for so I removed it.
cooperlees
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is minimal for now (didn't add any annotations, didn't turn on strict mode),
just so we can get started. In later PRs I can add more strictness.
Issue #478