Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeclimate formatter to never show source #14

Closed
wants to merge 5 commits into from
Closed

Update codeclimate formatter to never show source #14

wants to merge 5 commits into from

Conversation

etabegro
Copy link

@etabegro etabegro commented Jan 28, 2022

The codeclimate formatter breaks if the show source option is activated. This option would previously insert the source line, where the error occured as raw text into the json. This leads to parsing errors, when reading the generated json output. With the proposed changes, the source line will never be inserted.

Close #13

etabegro and others added 5 commits January 28, 2022 16:04
The codeclimate formatter breaks if the show source option is activated. This option would previously insert the source line, where the error occured as raw text into the json. This leads to parsing errors, when reading the generated json output. With the proposed changes, the source line will never be inserted.
@asottile
Copy link
Member

I'm planning to handle this in flake8 itself rather than every plugin needing to fix it PyCQA/flake8#1458

@asottile asottile closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update codeclimate formatter to never show source
2 participants