Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: Drop flake8-polyfill dependency #186

Closed
wants to merge 1 commit into from

Conversation

arkivm
Copy link

@arkivm arkivm commented Nov 26, 2021

Newer versions (> 3.x) of flake8 no longer require flake8-polyfill

Fixes #185
Also refer PyCQA/flake8-polyfill#14

Newer versions (> 3.x) of flake8 no longer require flake8-polyfill
@sigmavirus24
Copy link
Member

flake8-polyfill is still in use

from flake8_polyfill import options
def add_options(cls, parser):
options.register(parser, '--ignore-names',
default=_default_ignore_names,
action='store',
type='string',
parse_from_config=True,
comma_separated_list=True,
help='List of names or glob patterns the pep8-naming '
'plugin should ignore. (Defaults to %default)')
options.register(parser, '--classmethod-decorators',
default=_default_classmethod_decorators,
action='store',
type='string',
parse_from_config=True,
comma_separated_list=True,
help='List of method decorators pep8-naming plugin '
'should consider classmethods (Defaults to '
'%default)')
options.register(parser, '--staticmethod-decorators',
default=_default_staticmethod_decorators,
action='store',
type='string',
parse_from_config=True,
comma_separated_list=True,
help='List of method decorators pep8-naming plugin '
'should consider staticmethods (Defaults to '
'%default)')

@arkivm
Copy link
Author

arkivm commented Nov 26, 2021

oops. my bad. didn't really check where it is used. will fix. thank you

edit: It looks non-trivial. Do you have any suggestions on how do I go about removing this dep?

@jparise
Copy link
Member

jparise commented May 20, 2022

oops. my bad. didn't really check where it is used. will fix. thank you

edit: It looks non-trivial. Do you have any suggestions on how do I go about removing this dep?

The options need to be registered directly with parser in add_options() rather than going through the options.register() compatibility wrapper.

@jparise
Copy link
Member

jparise commented May 20, 2022

#199 is my take on removing this dependency.

@jparise
Copy link
Member

jparise commented May 23, 2022

Closed by #199

@jparise jparise closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop dependency on flake8-polyfill
3 participants