feat: add allow prerelease flag #2006

fatelei · 2024-03-23T16:06:54Z

No description provided.

netlify · 2024-03-23T16:07:10Z

✅ Deploy Preview for maturin-guide ready!

Name	Link
🔨 Latest commit	`400f0e7`
🔍 Latest deploy log	https://app.netlify.com/sites/maturin-guide/deploys/661679ee1a79340008f6768a
😎 Deploy Preview	https://deploy-preview-2006--maturin-guide.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/build_options.rs

messense · 2024-04-10T12:13:49Z

src/build_options.rs

@@ -587,6 +591,16 @@ impl BuildOptions {
            self.find_interpreters(&bridge, &interpreter, &target, None, generate_import_lib)?
        };

+        if !self.allow_prereleases {
+            interpreter.retain(|interp| {
+                let version = Version::new([interp.config.major as u64, interp.config.minor as u64]);


This won't be enough, I think it also need patch version.

Python 3.13.0a6 (main, Apr 10 2024, 01:20:43) [GCC 12.2.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import sys >>> sys.version_info sys.version_info(major=3, minor=13, micro=0, releaselevel='alpha', serial=6) >>> sys.version '3.13.0a6 (main, Apr 10 2024, 01:20:43) [GCC 12.2.0]'

interp config only has major and minor, missing micro，we should pass minor to it?

You can modify interp config to add more detailed version info.

Perhaps we can remove major and minor, add version: pep440_rs::Version instead to interpreter config and maybe other places. I might give it a try on the weekend.

fatelei changed the title ~~feat: add allow prerelease flag~~ WIP: feat: add allow prerelease flag Mar 23, 2024

fatelei changed the title ~~WIP: feat: add allow prerelease flag~~ Draft: feat: add allow prerelease flag Mar 23, 2024

messense reviewed Mar 24, 2024

View reviewed changes