Update PyClassGetterGenerator to allow IntoPyObject conversion for Deref::Target
#4990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
commented
Mar 18, 2025
| @@ -70,3 +70,19 @@ probe!(IsSync); | |||
| impl<T: Sync> IsSync<T> { | |||
| pub const VALUE: bool = true; | |||
| } | |||
|
|
|||
| probe!(IsDerefIntoPyObject); | |||
There was a problem hiding this comment.
I would like to implement this for T: Deref, for<'a, 'py> &'a T::Target: IntoPyObject<'py> but that will overflow the recursion limit because of the interaction with the Deref implementation of Bound. Is their another way to make this work for user defined wrappers?
bschoenmaeckers
force-pushed
the
container-specilization
branch
from
b5b0477 to
77b8a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation for #4987 as of comment #4987 (comment).