Refactor gen #31
Open
Refactor gen #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engelsgeduld
requested changes
Apr 23, 2025
There was a problem hiding this comment.
Commit messages must follow these rules https://www.conventionalcommits.org/en/v1.0.0/#specification. This makes it easier to understand what you have done.
Message like "Update some_file_name.py" doesn’t convey what was actually changed — that kind of information is already visible in the diff. Message would be:
refactor(api): unify NMM generator interface, replace canonical_generate and classical_generate with generate
| @@ -9,7 +9,7 @@ | |||
| class NMGenerator(AbstractGenerator): | |||
|
|
|||
| @staticmethod | |||
| def classical_generate(mixture: AbstractMixtures, size: int) -> tpg.NDArray: | |||
| def generate(mixture: AbstractMixtures, size: int) -> tpg.NDArray: | |||
| """Generate a sample of given size. Classical form of NMM | |||
| @@ -9,7 +9,7 @@ | |||
| class NMVGenerator(AbstractGenerator): | |||
|
|
|||
| @staticmethod | |||
| def classical_generate(mixture: AbstractMixtures, size: int) -> tpg.NDArray: | |||
| def generate(mixture: AbstractMixtures, size: int) -> tpg.NDArray: | |||
| """Generate a sample of given size. Classical form of NMVM | |||
| @@ -9,7 +9,7 @@ | |||
| class NVGenerator(AbstractGenerator): | |||
|
|
|||
| @staticmethod | |||
| def classical_generate(mixture: AbstractMixtures, size: int) -> tpg.NDArray: | |||
| def generate(mixture: AbstractMixtures, size: int) -> tpg.NDArray: | |||
Update nm_generator.py Update nmv_generator.py Update nv_generator.py Changed NM/NMW/NV generators: if the mixture form is canonical, the beta parameter is not considered in the output. Update abstract_mixture.py Remembered parameter for mixture form. Update test_mixing_normal.py Update nm_sigma_estimation_comparison.ipynb Now using the updated generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.