Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on note #328

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Warn on note #328

wants to merge 2 commits into from

Conversation

jeisch
Copy link

@jeisch jeisch commented Aug 2, 2022

I'm using Ngspice version 36

During some simulations, I get messages like these on stderr:
Trying gmin = 1.0000E-05 Warning: Further gmin increment
and
Trying gmin = 3.2781E-05 Note: One successful gmin step

Since neither starts with "Warning:" they are treated as errors, despite the simulation being successful. These modifications allow the "Warning:" to be anywhere in the line to be treated as a warning, and also treats lines that include "Note:" in them as a warning.

jeisch added 2 commits August 1, 2022 23:40
for instance: Trying gmin =   1.0000E-05 Warning: Further gmin increment
which may later succeed.
@infinitymdm
Copy link

This PR is very similar to #313 , though I like how your solution allows keywords to appear anywhere in the line.

That said, shouldn't "Note" be treated as info rather than a warning, as in #313 ? Perhaps you could take some of the ideas they have over there and improve your PR a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants