Fix common bug in parsing of UTC datetimes; remove dateutil #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a common bug related to parsing UTC datetimes, fixes the timezone of Opta F24 data and removes the
dateutil
dependency.The following conventions are used:
astimezone
->replace
Often, datetimes are specified as a string and use the UTC timezone. In kloppy, we want to parse these a timezone-aware
datetime
. Then, then string was usually parsed and converted to a timezone-aware datetime as follows:The correct implementation is:
The former changes the timezone, while the latter sets the timezone (i.e., makes the datetime timezone-aware).
Opta F24 timezone
According to the documentation, timestamps in the F24 files use the timezone "Europe/London".
Remove
dateutil
We know the exact format of the date string in advance. Hence, we don't need
dateutil
'sparser
module.