Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep GitHub Actions up to date with GitHub's Dependabot #708

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

@rgommers
Copy link
Member

rgommers commented Mar 8, 2024

Hi @cclauss, thank you for this PR, however I'm not really interested in adding Dependabot. It has pretty bad habits and a history of spamming open source projects. It's also overkill for a very slow-moving repo like this one. Having weekly or even monthly bot commits would mean ~50% of all PRs being from bots, and that's usually a bad sign and too much churn.

@cclauss
Copy link
Contributor Author

cclauss commented Mar 8, 2024

Patterns * means that there can only be one pull request open at a time. GitHub Actions rarely receive major upgrades. Monthly means a theoretical maximum of 12 PRs a year (only one at any given time) and probably much less.

@agriyakhetarpal
Copy link
Collaborator

Hi @cclauss, I was adding this too in the meanwhile on a working branch of mine, when I happened to notice your PR – @rgommers, I would suggest getting this in so that we can have updates for GitHub Actions, now that we will be pushing nightly wheels soon (#706, scientific-python/upload-nightly-action#75).

I would be happy to be assigned for review on such PRs. We could enable the rebase option as well in case that can help keep a single PR clean.

P.S. I was initially adding it on a daily cadence (I like that personally), but having it monthly would be perfectly fine.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that is two votes in favor - let's give this a go. Thanks @cclauss

@rgommers rgommers merged commit bbe563c into PyWavelets:master Mar 12, 2024
15 checks passed
@rgommers rgommers added this to the v1.6.0 milestone Mar 12, 2024
@cclauss cclauss deleted the patch-1 branch March 12, 2024 19:10
@cclauss
Copy link
Contributor Author

cclauss commented Mar 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants