FIX, CI: Temporarily disable pytest's caching in Pyodide job
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pytest test suite is trying to generate additional files and it tries to save them to a filesystem that is for some reason read-only. Since this workflow runs only in a temporary CI job, the `.pyc` file generation can be disabled. Some other fixes are included as well: 1. pydantic<2 not needed anymore 2. Skip the job on forks 3. More readable condition for Anaconda upload step
rgommers
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
pytesttest suite tries to generate additional bytecode files after its completion, and it then tries to save them to a filesystem that is read-only for unexplored reasons. Since this workflow runs only in a temporary CI job, the.pycfile generation can be disabled with the internalpytestplugin using-p no:cacheprovider.Some other fixes are included as well:
pydantic<2is not needed anymoreThe workflow is passing on my fork, here: https://github.com/agriyakhetarpal/pywt/actions/runs/9287344567/job/25556120583
What issue does this PR reference?
Closes gh-742. For additional context: this PR fixes an unrelated error which was noted in #742 (comment), and the CI job is already picking up the latest Emscripten version that is coupled with
pyodide-buildusing the value retrieved by the$(pyodide config get emscripten_version)command.