Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ New role tags #2606

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Oct 11, 2024

Summary

fixes: #2474
cc @Lumabots

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner October 11, 2024 10:03
@pullapprove4 pullapprove4 bot requested a review from FrostByte266 October 11, 2024 10:03
@Paillat-dev Paillat-dev changed the title 🩹 Fix Role.is_integration() Fix 🩹 Role.is_integration() Oct 11, 2024
@Paillat-dev Paillat-dev changed the title Fix 🩹 Role.is_integration() fix: 🩹 Role.is_integration() Oct 11, 2024
@Lulalaby
Copy link
Member

Changelog

@Paillat-dev Paillat-dev force-pushed the fix-is-integration branch 2 times, most recently from 9270a61 to fb32e22 Compare October 11, 2024 16:06
@Paillat-dev
Copy link
Contributor Author

There. Maybe discord.RoleTags.is_integration() should be removed too ? That would be breaking tho.

@plun1331
Copy link
Member

plun1331 commented Oct 11, 2024

is_integration is for roles managed by integrations, such as patreon/twitch
is_bot_managed is for roles assigned to bots when added to a server by discord
is_premium_subscriber is for the server booster role managed by discord
managed is True if any of the above is True

In my testing, with this logic, is_integration works just fine and was never broken.
This should really be a documentation update, as the docs are misleading.

@Lulalaby
Copy link
Member

Do we cover the new tags also? Like for role subscription, server shop, etc

@plun1331
Copy link
Member

Do we cover the new tags also? Like for role subscription, server shop, etc

We do not, missing subscription_listing_id, available_for_purchase, guild_connections

@Lulalaby
Copy link
Member

@Paillat-dev
Copy link
Contributor Author

Yeah that was a documentation issue. I will change that instead.

@Paillat-dev Paillat-dev marked this pull request as draft October 11, 2024 20:17
@plun1331 plun1331 added documentation Improvements or additions to documentation priority: medium Medium Priority status: in progress Work in Progess feature Implements a feature API Reflection Discords API wasn't correctly reflected in the lib and removed on hold labels Oct 11, 2024
@plun1331 plun1331 added this to the v2.7 milestone Oct 11, 2024
@Paillat-dev
Copy link
Contributor Author

@plun1331 I might add the other tags too now that i'm here.

@plun1331
Copy link
Member

Go for it, shouldn't be too difficult

@plun1331
Copy link
Member

plun1331 commented Nov 2, 2024

I like keeping a clean history

makes it harder to see what you changed, and it all gets squashed anyways

Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar stuff

discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Paillat-dev

@Lulalaby Lulalaby merged commit 8d8fb2b into Pycord-Development:master Jan 7, 2025
27 checks passed
@Paillat-dev Paillat-dev deleted the fix-is-integration branch January 7, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib documentation Improvements or additions to documentation feature Implements a feature priority: medium Medium Priority status: in progress Work in Progess
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_integration return False even if its an integration
5 participants