-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ New role tags #2606
feat: ✨ New role tags #2606
Conversation
91ce47c
to
694a5c0
Compare
Changelog |
9270a61
to
fb32e22
Compare
There. Maybe |
In my testing, with this logic, |
Do we cover the new tags also? Like for role subscription, server shop, etc |
We do not, missing |
Yeah that was a documentation issue. I will change that instead. |
@plun1331 I might add the other tags too now that i'm here. |
Go for it, shouldn't be too difficult |
fb32e22
to
e593485
Compare
makes it harder to see what you changed, and it all gets squashed anyways |
Signed-off-by: Paillat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @Paillat-dev
Summary
fixes: #2474
cc @Lumabots
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.