pyomo.doe adding more verbose output for sensitivity analysis #3525
+32
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adowling2 @djlaky ready for early feedback |
|
Next step:
|
jsiirola
reviewed
Mar 25, 2025
pyomo/contrib/doe/doe.py
Outdated
Comment on lines
1534
to
1536
| if abs(E_vals.imag[E_ind]) > 1e-8: | ||
| self.logger.warning( | ||
| "Eigenvalue has imaginary component greater than 1e-6, contact developers if this issue persists." | ||
| "Eigenvalue has imaginary component greater than 1e-8, contact developers if this issue persists." |
There was a problem hiding this comment.
nit: this is why "embedded constants are evil". An improved solution would be to declare a module-level constant (maybe IMAG_THRESHOLD) and then use that both in the test and in the message.
|
@smondal13 See #3532 for an example of what @jsiirola is suggesting |
…alue checking in compute_FIM_full_factorial()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: