Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for correctness of the supplied script #322

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

nielstron
Copy link
Contributor

This is to avoid users accidentally adding script inputs with the wrong script and then get cryptic errors from ogmios.

@nielstron nielstron force-pushed the feat/check_script_hash_match branch from 5399f27 to b96c66e Compare March 1, 2024 08:23
This is to avoid users accidentally adding script inputs with the wrong
script and then get cryptic errors from ogmios.
@nielstron nielstron force-pushed the feat/check_script_hash_match branch from b96c66e to 86297a7 Compare March 1, 2024 08:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (efbc2d2) to head (7cf1a00).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   83.42%   83.56%   +0.13%     
==========================================
  Files          29       29              
  Lines        3705     3706       +1     
  Branches      929      931       +2     
==========================================
+ Hits         3091     3097       +6     
+ Misses        448      446       -2     
+ Partials      166      163       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nielstron nielstron merged commit 4245029 into Python-Cardano:main Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants