Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to Ogmios v6 backend #398

Merged

Conversation

theeldermillenial
Copy link
Contributor

@theeldermillenial theeldermillenial commented Nov 16, 2024

A couple of months ago, I added a path argument to Ogmios.

https://gitlab.com/viperscience/ogmios-python/-/merge_requests/13

This PR adds support for the path argument in the Ogmios chain context.

For some additional context, the path argument allows you to specify a path in the IP/URL of the Ogmios endpoint. We had a specific use case for this where we wanted to serve Ogmios for different networks on my.url.io/mainnet and my.url.io/preprod.

I don't believe the change has been deployed on Ogmios yet, so this should be merged once that change is released.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (b9829ee) to head (8abf39c).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/backend/ogmios_v6.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          32       32           
  Lines        4202     4203    +1     
  Branches     1052     1052           
=======================================
+ Hits         3600     3601    +1     
  Misses        423      423           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nielstron nielstron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, but I think an unintended change snuck in

pycardano/backend/ogmios_v6.py Outdated Show resolved Hide resolved
@cffls
Copy link
Collaborator

cffls commented Dec 7, 2024

LGTM, pushed a minor fix.

@theeldermillenial theeldermillenial merged commit f21348f into Python-Cardano:main Jan 10, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants