Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra fee buffer #404

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

theeldermillenial
Copy link
Contributor

Currently the code adds in the fee buffer twice.

if self.fee_buffer is not None:

if self.fee_buffer is not None:

This PR removes the addition of the fee buffer from _add_change_and_fee rather than from _estimate_fee, since _estimate_fee is used in a validation check during the build step and removing it from _estimate_fee could lead to edge cases. Also, _estimate_fee is used during _add_change_and_fee.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.72%. Comparing base (b9829ee) to head (1e2293d).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   85.67%   85.72%   +0.04%     
==========================================
  Files          32       32              
  Lines        4202     4202              
  Branches     1052     1051       -1     
==========================================
+ Hits         3600     3602       +2     
+ Misses        423      422       -1     
+ Partials      179      178       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cffls cffls merged commit 075ab91 into Python-Cardano:main Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants