Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code adds in the fee buffer twice.
pycardano/pycardano/txbuilder.py
Line 725 in 38c348d
pycardano/pycardano/txbuilder.py
Line 1121 in 38c348d
This PR removes the addition of the fee buffer from
_add_change_and_fee
rather than from_estimate_fee
, since_estimate_fee
is used in a validation check during the build step and removing it from_estimate_fee
could lead to edge cases. Also,_estimate_fee
is used during_add_change_and_fee
.