Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for address and key #410

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

tacmota
Copy link
Contributor

@tacmota tacmota commented Dec 20, 2024

No description provided.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (d00442e) to head (18c9d6e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/key.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   86.40%   88.13%   +1.72%     
==========================================
  Files          32       32              
  Lines        4201     4204       +3     
  Branches     1047     1048       +1     
==========================================
+ Hits         3630     3705      +75     
+ Misses        399      348      -51     
+ Partials      172      151      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cffls cffls merged commit d7d2053 into Python-Cardano:main Dec 21, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants