-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wallet classes #89
base: main
Are you sure you want to change the base?
Conversation
Quick update-- I've finally managed to integrate mypy so that the checks do not fail anymore. In addition I've gotten coverage up to ~44%. Still some tests to write but I'm closing in on this. |
How can I help with this? I can't see the logs for the failed checks as it was too long ago. I am working on a project that would benefit from having the wallet stuff abstracted away into PyCardano. |
@KINGH242 that's great! This PR is staled and I completely forget about it.. I think a few type checks are failing. If those are fixed we should be able to merge it. |
Hey all, I dropped the ball a bit on this one! I think I got stuck with test writing-- I recall that I mainly had trouble with the mocking of the blockfrost API and tx submission as it's something I had no experience with. Also happy to help out wherever possible and finally get this done. |
Hey @astrojarred, I added some test and fixed a few things to allow it to work with the latest changes. I submitted a PR here astrojarred#33 |
Updates and tests
This is still a WIP but I wanted to get the ball rolling on this! Lots of basic functionality is now here, along with the first few tests and examples. See
/examples/wallet.py
for some examples of the most basic functionality.Current capabilities:
Future additions (possibly later PRs):
HDWallet
)Now currently figuring out how to write tests for the transaction methods, using
test_transaction.py
for inspiration.