Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to remove use of deprecated constructs #362

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jenshnielsen
Copy link
Collaborator

Including soon to be deprecated instrument.get/set from QCoDeS see microsoft/Qcodes#6086

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 4.65116% with 41 lines in your changes missing coverage. Please review.

Project coverage is 10.73%. Comparing base (05a0ac6) to head (97ca172).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes_contrib_drivers/drivers/Spectrum/M4i.py 0.00% 13 Missing ⚠️
...trib_drivers/drivers/ZurichInstruments/ZIHDAWG8.py 22.22% 7 Missing ⚠️
src/qcodes_contrib_drivers/drivers/QuTech/IVVI.py 0.00% 6 Missing ⚠️
...codes_contrib_drivers/drivers/BlueFors/BlueFors.py 0.00% 4 Missing ⚠️
...contrib_drivers/drivers/ERAInstruments/erasynth.py 0.00% 4 Missing ⚠️
..._drivers/drivers/StanfordResearchSystems/SIM928.py 0.00% 4 Missing ⚠️
...ontrib_drivers/drivers/OxfordInstruments/ILM200.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   10.73%   10.73%   -0.01%     
==========================================
  Files         134      134              
  Lines       17954    17959       +5     
==========================================
  Hits         1928     1928              
- Misses      16026    16031       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue Sep 25, 2024
Merged via the queue into QCoDeS:main with commit a100d0c Sep 25, 2024
8 of 10 checks passed
@jenshnielsen jenshnielsen deleted the fix_deprecation branch September 25, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants